-
Notifications
You must be signed in to change notification settings - Fork 179
Add steps to configure document and field level security in Serverless #3950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
porting comment over from your other PR + some additional feedback
we have this page now tagged for serverless, but the intro page for user roles doesn't have a serverless tag. these pages should be in conversation with each other: the page at the top of the pile should always be an overview that has a superset of all of the tags of the child pages.
this page needs some structural changes so it's easier to scan - finding the serverless procedures is not intuitive here, and it's not clear that the other pieces of the procedure are for stack only. fix likely is tabs
other sections need to be tagged because some of them don't apply to serverless (e.g. the cross-cluster API keys one - CCS doesn't work for serverless)
|
Hi @shainaraskas, as per your comment, I had another look at all the tagging of the pages in Users and roles and here's what stands out:
SuggestionIt almost seems like these new steps I've added would be better placed in this section in the Serverless project custom roles doc. So I'm suggesting to move them there, and only keep the note that links to it in the Controlling access at the document and field level: What do you think? Would it make more sense to keep the Serverless docs separate and avoid introducing more confusion? |
|
to me, this is a signal that the page is possibly badly placed in the IA. we also really need the queries to be visible to people configuring document and field level security for serverless. consider:
suspect stuff like run_as might have similar problems to the doc/field level access page, so keep that in mind when choosing a solution my guiding principle is generally "if someone googles this, what is the easiest way for them to land in the correct place?" generally, keeping the info together is the path of least resistance for readers. |
maggieghamry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!


Fixes #426
On the Controlling access at the document and field level page, I've added: